[libcamera-devel] [PATCH] Added alternative to meson install command, if it fails with --user argument

Sebastian Fricke sebastian.fricke at posteo.net
Mon Mar 22 09:28:14 CET 2021


Hey Vedant,

On 22.03.2021 13:48, Vedant Paranjape wrote:
>Sure, will do that. Should I add the error message in commit message or the
>readme?

I think you should place the error message into the commit message so
that it becomes clear which problem is tackled by this patch. But if it
is a very long error message, I would write a short version into the
commit message and the long version into this mail-series.

>
>On Mon, 22 Mar, 2021, 13:41 Sebastian Fricke, <sebastian.fricke at posteo.net>
>wrote:
>
>> Hey Vedant,
>>
>> Thank you for the patch.
>>
>> I believe this patch would benefit from a description, that makes clear
>> why this change is needed. The current version feels like you've hit a
>> quite specific problem and you provide a quite generic solution to it.
>>
>> On 22.03.2021 13:10, Vedant Paranjape wrote:
>> >Signed-off-by: Vedant Paranjape <vedantparanjape160201 at gmail.com>
>> >---
>> > README.rst | 4 +++-
>> > 1 file changed, 3 insertions(+), 1 deletion(-)
>> >
>> >diff --git a/README.rst b/README.rst
>> >index 1427c714..0bfd39d9 100644
>> >--- a/README.rst
>> >+++ b/README.rst
>> >@@ -56,7 +56,9 @@ Meson Build system: [required]
>> >
>> >             pip3 install --user meson
>> >             pip3 install --user --upgrade meson
>> >-
>> >+
>> >+        If this fails, retry with `pip3 install meson`
>> >+
>>
>> This feels a little too broad as there are multiple reasons for this
>> command to fail. Can you show the error message that you encountered?
>>
>> > for the libcamera core: [required]
>> >         python3-yaml python3-ply python3-jinja2
>> >
>> >--
>> >2.25.1
>>
>> Greetings,
>> Sebastian
>>
>> >
>> >_______________________________________________
>> >libcamera-devel mailing list
>> >libcamera-devel at lists.libcamera.org
>> >https://lists.libcamera.org/listinfo/libcamera-devel
>>


More information about the libcamera-devel mailing list