[libcamera-devel] [PATCH] Added alternative to meson install command, if it fails with --user argument

[paul.elder at ideasonboard.com]

Hello Vedant,

Thank you for the patch.

As Jacopo pointed out, the subject should be more concise. You're also
missing a changelog.

On Mon, Mar 22, 2021 at 01:10:56PM +0530, Vedant Paranjape wrote:
> Signed-off-by: Vedant Paranjape <vedantparanjape160201 at gmail.com>
> ---
>  README.rst | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/README.rst b/README.rst
> index 1427c714..0bfd39d9 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -56,7 +56,9 @@ Meson Build system: [required]
>  
>              pip3 install --user meson
>              pip3 install --user --upgrade meson
> -
> +        
> +        If this fails, retry with `pip3 install meson`
> +        

I don't think this is the right place, and I don't think there's enough
information.

This is the dependencies section, so I think your supplemental
information should go before "Dependencies", and maybe after the code
that's after "To fetch the sources, build and install".

iirc the issue was about a potential version mismatch beteween the
version that the root user uses, and the version that your user uses. So
you should outline this issue, and then provide a solution to it. Maybe
recommending not to use --user if meson is already installed
system-wide?


Paul

>  for the libcamera core: [required]
>          python3-yaml python3-ply python3-jinja2
>  
> -- 
> 2.25.1