[libcamera-devel] [PATCH] Added alternative to meson install command, if it fails with --user argument

[Vedant Paranjape]

Thanks for the feedback! Is there any way to enforce character limit ?

On Mon, Mar 22, 2021 at 3:24 PM <paul.elder at ideasonboard.com> wrote:

> Hi Vedant,
>
> Thank you for the patch.
>
> The subject should be more concise, limited to 75 characters (you can go
> over by one word, maybe). I think Jacopo had a pretty good suggestion in
> his review of v1.
>
> Also for v2 the patch subject should have [PATCH v2], which you can put
> in automatically with git format-patch -v 2
>
> On Mon, Mar 22, 2021 at 03:01:03PM +0530, Vedant Paranjape wrote:
> > While installing meson using pip3 install --user meson, due to python
> path issues, build.ninja can't be located by ninja.
>
> All lines in the changelog should be line wrapped to 75 characters per
> line (with some exceptions allowed, for compiler error messages, for
> example).
>
> As for the content I think you have the gist. I would want some more
> elaboration on what kind of python path issues, though.
>
> > It gives the following error on ninja -C build install:
> >
> > ninja: Entering directory `build'
> > ninja: error: loading 'build.ninja': No such file or directory
> >
> > After uninstalling meson and installing it without --user argument
> solved the issue, as discussed with pinchartl on irc.
>
> Same here on line length.
>
> Uninstalling meson where? From pip, or from the system package manager?
>
> >
> > Signed-off-by: Vedant Paranjape <vedantparanjape160201 at gmail.com>
> > ---
> >  README.rst | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/README.rst b/README.rst
> > index 1427c714..0bfd39d9 100644
> > --- a/README.rst
> > +++ b/README.rst
> > @@ -56,7 +56,9 @@ Meson Build system: [required]
> >
> >              pip3 install --user meson
> >              pip3 install --user --upgrade meson
> > -
> > +
> > +        If this fails, retry with `pip3 install meson`
> > +
>
> I assume you'll upgrade this in v3 :)
>
>
> Paul
>
> >  for the libcamera core: [required]
> >          python3-yaml python3-ply python3-jinja2
> >
> > --
> > 2.25.1
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20210322/282032b3/attachment-0001.htm>