[libcamera-devel] [PATCH] Add alternative meson install command

[paul.elder at ideasonboard.com]

Hi Vedant,

Thank you for the patch.

This is v3, so the subject should have [PATCH v3]

On Mon, Mar 22, 2021 at 03:35:50PM +0530, Vedant Paranjape wrote:
> Changelog:
> 
> * Updated README.rst to describ meson install issue

This should go below, as shown below, in imperative form.

You don't need "Changelog:" either, this entire section (until "---") is
called the changelog.

> 
> While installing meson using pip3 install --user meson, due to python path issues, build.ninja can't be located by ninja.

Line length 75 characters.

> It gives the following error on ninja -C build install:
> 
> ninja: Entering directory `build'
> ninja: error: loading 'build.ninja': No such file or directory
> 
> After uninstalling meson and installing it without --user argument solved the issue.

Update README.rst to describe the meson install issue and solutions.

> 
> Signed-off-by: Vedant Paranjape <vedantparanjape160201 at gmail.com>
> ---

Right here, you can put what changed between versions, like:

Changes in v3:
- expanded the explanation of the issue
- moved the explanation out of the dependencies section

This part is more lenient and freeform, as its purpose is to help
reviewers know what changed in between versions (afaik github just
discards it?) and it won't be committed.

>  README.rst | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/README.rst b/README.rst
> index 1427c714..b86bcc1d 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -37,6 +37,13 @@ To fetch the sources, build and install:
>    meson build
>    ninja -C build install
>  
> +Several users have reported issues with meson installation, crux of the issue is a potential version
> +mismatch between the version that is installed in root, and version that the normal user

s/is installed in root/that root uses/

s/and version/and the version/

> +uses. On calling meson, it can't find the build.ninja module. This can be solved by two ways: 

s/by/in/

Was the issue occurring when you "call meson" to generate the build
directory:

meson build

Or was it when you try to ninja install:

ninja -C build install

> +
> +1) Don't install meson again if it is already installed system-wide
> +2) If you still went ahead and installed, uninstall meson using pip, and install again without --user argument

For all of this, line length at 80 characters.

s/--user/the --user/

I think "If you still went ahead and installed" should be worded
differently. Maybe "If a meson that is different from the system-wide
meson is installed"? I'm not too certain about this, so it's up to you.


Paul

> +
>  Dependencies
>  ~~~~~~~~~~~~
>  
> -- 
> 2.25.1