[libcamera-devel] [PATCH 1/3] libcamera: stream: Add controlList attribute

[Jacopo Mondi]

Hi Marian,

On Mon, Mar 22, 2021 at 11:42:40AM +0100, Marian Cichy wrote:
> By adding a controlList to the stream attributes, we have access to
> several more configuration parameters for a stream. In this patch
> series, it is for now only used to access the frame duration of a sensor.
>
> Signed-off-by: Marian Cichy <m.cichy at pengutronix.de>
> ---
>  include/libcamera/stream.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h
> index bb47c390..a6347e31 100644
> --- a/include/libcamera/stream.h
> +++ b/include/libcamera/stream.h
> @@ -13,6 +13,7 @@
>  #include <vector>
>
>  #include <libcamera/buffer.h>
> +#include <libcamera/controls.h>
>  #include <libcamera/geometry.h>
>  #include <libcamera/pixel_format.h>
>
> @@ -44,6 +45,7 @@ struct StreamConfiguration {
>  	Size size;
>  	unsigned int stride;
>  	unsigned int frameSize;
> +	ControlList controls;

Documentation is missing.

In general, as discussed on irc, I guess this is an acceptable first
step to be able to retrieve per-stream information.

>
>  	unsigned int bufferCount;
>
> --
> 2.29.2
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel