[libcamera-devel] [PATCH v5] Add alternative meson install command

[paul.elder at ideasonboard.com]

Hi Vedant,

Thank you for the patch.

On Tue, Mar 23, 2021 at 12:54:00AM +0530, Vedant Paranjape wrote:
> Changes in v5:
> * Updated README.rst to describe meson install issue
> * Removed "changelog" heading from commit message
> * Fixed few grammatical mistakes
> * Reworded few sentences

This belongs below ---

> 
> While installing meson using pip3 install --user meson, due to python
> path issues, build.ninja can't be located by ninja. meson generates
> ninja files fine, but then when you run ninja, it is unable to find
> meson's build.ninja python module due to path issues.

I think you need some more detail on "path issues".

Also I think you should take in what what Nicolas said in review of v3.


Paul

> It gives the following error on ninja -C build install:
> 
> ninja: Entering directory `build'
> ninja: error: loading 'build.ninja': No such file or directory
> 
> After uninstalling meson using pip3 and installing it again using pip
> without --user argument solved the issue.
> 
> Signed-off-by: Vedant Paranjape <vedantparanjape160201 at gmail.com>
> ---
>  README.rst | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/README.rst b/README.rst
> index 1427c714..39213dc4 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -37,6 +37,22 @@ To fetch the sources, build and install:
>    meson build
>    ninja -C build install
>  
> +Several users have reported issues with meson installation, crux of the issue is a potential version
> +mismatch between the version that root uses, and the version that the normal user
> +uses. On calling `ninja -C build`, it can't find the build.ninja module. This the snippet of error message,
> +
> +:: 
> +
> +  ninja: Entering directory `build'     
> +  ninja: error: loading 'build.ninja': No such file or directory
> +
> +This can be solved in two ways: 
> +
> +1) Don't install meson again if it is already installed system-wide.
> +2) If meson which is different from system-wide is already installed, 
> +uninstall that meson using pip3, and install again without the --user 
> +argument.
> +
>  Dependencies
>  ~~~~~~~~~~~~
>  
> -- 
> 2.25.1