[libcamera-devel] [PATCH] libcamera: camera_manager: Document the CameraManager destructor

[Sebastian Fricke]

Hello Laurent,

Thanks for the patch.

On 23.03.2021 16:16, Laurent Pinchart wrote:
>The destructor stops the camera manager if it is running. This is at the
>moment an implementation detail, but makes sense to guarantee in the
>API. Document it.
>
>Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>---
> src/libcamera/camera_manager.cpp | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp
>index 67641a555e1e..9e4d9c391f09 100644
>--- a/src/libcamera/camera_manager.cpp
>+++ b/src/libcamera/camera_manager.cpp
>@@ -269,6 +269,11 @@ CameraManager::CameraManager()
> 	self_ = this;
> }
>
>+/**
>+ * \brief Destroy the camera manager
>+ *
>+ * Destroying the camera manager stops it if it is currently running.
>+ */
> CameraManager::~CameraManager()
> {
> 	stop();
>-- 
>Regards,

Reviewed-by: Sebastian Fricke <sebastian.fricke at posteo.net>

Greetings,
Sebastian
>
>Laurent Pinchart
>
>_______________________________________________
>libcamera-devel mailing list
>libcamera-devel at lists.libcamera.org
>https://lists.libcamera.org/listinfo/libcamera-devel