[libcamera-devel] [PATCH] pipeline: raspberrypi: Remove unused getFormat call

Sebastian Fricke sebastian.fricke at posteo.net
Sun Mar 28 16:27:12 CEST 2021


The comment states, that we get the device format to pass it to the IPA,
but the variable `sensorFormat` is not used again after it's assignment.
Remove it, together with the comment.

Signed-off-by: Sebastian Fricke <sebastian.fricke at posteo.net>
---
Tested on Raspberry Pi 4 with IMX219 without issues.
---
 src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
index 378a5227..f22e286e 100644
--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
@@ -1238,9 +1238,6 @@ int RPiCameraData::configureIPA(const CameraConfiguration *config)
 	std::map<unsigned int, ControlInfoMap> entityControls;
 	ipa::RPi::IPAConfig ipaConfig;
 
-	/* Get the device format to pass to the IPA. */
-	V4L2DeviceFormat sensorFormat;
-	unicam_[Unicam::Image].dev()->getFormat(&sensorFormat);
 	/* Inform IPA of stream configuration and sensor controls. */
 	unsigned int i = 0;
 	for (auto const &stream : isp_) {
-- 
2.25.1



More information about the libcamera-devel mailing list