[libcamera-devel] [PATCH] ipa: raspberrrypi: Remove duplicate comment
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Sun Mar 28 18:51:27 CEST 2021
Hi Sebastian,
Thank you for the patch.
On Sun, Mar 28, 2021 at 09:59:54AM +0200, Sebastian Fricke wrote:
> The exact same comment is used two times within 5 lines.
> Remove one of them as it is redundant.
>
> Signed-off-by: Sebastian Fricke <sebastian.fricke at posteo.net>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> src/ipa/raspberrypi/raspberrypi.cpp | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
> index 1c928b72..ed2d9a54 100644
> --- a/src/ipa/raspberrypi/raspberrypi.cpp
> +++ b/src/ipa/raspberrypi/raspberrypi.cpp
> @@ -208,7 +208,6 @@ void IPARPi::start(const ControlList &controls, ipa::RPi::StartConfig *startConf
> agcStatus.shutter_time = 0.0;
> agcStatus.analogue_gain = 0.0;
>
> - /* SwitchMode may supply updated exposure/gain values to use. */
> metadata.Get("agc.status", agcStatus);
> if (agcStatus.shutter_time != 0.0 && agcStatus.analogue_gain != 0.0) {
> ControlList ctrls(sensorCtrls_);
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list