[libcamera-devel] [PATCH v2 2/3] android: CameraDevice: Log rotation variables in camera3_stream
Hirokazu Honda
hiroh at chromium.org
Mon Mar 29 00:45:27 CEST 2021
|rotation| and |crop_rotate_scale_degrees| are important info of
a configuration. They should be logged.
Signed-off-by: Hirokazu Honda <hiroh at chromium.org>
Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>
---
src/android/camera_device.cpp | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
index c5e55a18..d3368b19 100644
--- a/src/android/camera_device.cpp
+++ b/src/android/camera_device.cpp
@@ -256,6 +256,20 @@ void sortCamera3StreamConfigs(std::vector<Camera3StreamConfig> &unsortedConfigs,
unsortedConfigs = sortedConfigs;
}
+const char *rotationToString(int rotation)
+{
+ switch (rotation) {
+ case CAMERA3_STREAM_ROTATION_0:
+ return "ROTATION_0";
+ case CAMERA3_STREAM_ROTATION_90:
+ return "ROTATION_90";
+ case CAMERA3_STREAM_ROTATION_180:
+ return "ROTATION_180";
+ case CAMERA3_STREAM_ROTATION_270:
+ return "ROTATION_270";
+ }
+ return "ROTATION_INVALID";
+}
/*
* Returns where crop_rotate_scale_degrees in all camera3_stream in stream_list
* are valid.
@@ -1625,6 +1639,9 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)
<< ", width: " << stream->width
<< ", height: " << stream->height
<< ", format: " << utils::hex(stream->format)
+ << ", rotation: " << rotationToString(stream->rotation)
+ << ", crop_rotate_scale_degrees: "
+ << rotationToString(stream->crop_rotate_scale_degrees)
<< " (" << format.toString() << ")";
if (!format.isValid())
--
2.31.0.291.g576ba9dcdaf-goog
More information about the libcamera-devel
mailing list