[libcamera-devel] [PATCH v2 3/3] android: CameraDevice: Deny non ROTATION_0 stream configuration

[Laurent Pinchart]

Hi Hiro,

Thank you for the patch.

On Mon, Mar 29, 2021 at 07:45:28AM +0900, Hirokazu Honda wrote:
> Libcamera doesn't handle crop_rotate_scale_degrees. Therefore,

s/Libcamera/libcamera/

> if it is requested, that is, crop_rotate_scale_degrees is not
> CAMERA3_STREAM_ROTATION_0, the configuration should fail.
> 
> Signed-off-by: Hirokazu Honda <hiroh at chromium.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/android/camera_device.cpp | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> index d3368b19..11c0f35a 100644
> --- a/src/android/camera_device.cpp
> +++ b/src/android/camera_device.cpp
> @@ -1647,6 +1647,13 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)
>  		if (!format.isValid())
>  			return -EINVAL;
> 
> +		/* \todo Support rotation. */
> +		if (stream->rotation != CAMERA3_STREAM_ROTATION_0 ||
> +		    stream->crop_rotate_scale_degrees != CAMERA3_STREAM_ROTATION_0) {
> +			LOG(HAL, Error) << "Rotation is not supported";
> +			return -EINVAL;
> +		}
> +
>  		/* Defer handling of MJPEG streams until all others are known. */
>  		if (stream->format == HAL_PIXEL_FORMAT_BLOB) {
>  			if (jpegStream) {

-- 
Regards,

Laurent Pinchart