[libcamera-devel] [PATCH v6] Add alternative meson install command

[paul.elder at ideasonboard.com]

Hi Vedant,

On Sun, Mar 28, 2021 at 12:50:48AM +0530, Vedant Paranjape wrote:
> Changes in v6:
> * Updated README.rst to describe meson install issue
> * Removed "changelog" heading from commit message
> * Fixed few grammatical mistakes
> * Reworded few sentences
> * Added a new troubleshooting section in readme,
> and shifted meson issue to that section

This shouldn't be committed into the git history, and so should be after
--- (marked with <1>).

> While installing meson using pip3 install --user meson, due to python
> path issues, build.ninja can't be located by ninja. meson generates
> ninja files fine, but then when you run ninja, it is unable to find
> meson's build.ninja python module due to path issues.
> It gives the following error on ninja -C build install:
> 
> ninja: Entering directory `build'
> ninja: error: loading 'build.ninja': No such file or directory
> 
> After uninstalling meson using pip3 and installing it again using pip
> without --user argument solved the issue.

Good description of the problem and motivation. You should add just one
line about what you did in the patch, like about adding a solution to
the issue in a troubleshooting section.

> 
> Signed-off-by: Vedant Paranjape <vedantparanjape160201 at gmail.com>
> ---

<1>

>  README.rst | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/README.rst b/README.rst
> index 1427c714..fff67762 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -104,3 +104,22 @@ onto the default video display element on your system.
>    gst-launch-1.0 libcamerasrc camera-name="Camera 1" ! videoconvert ! autovideosink
>  
>  .. section-end-getting-started
> +
> +Troubleshooting
> +~~~~~~~~~~~~~~~
> +
> +Several users have reported issues with meson installation, crux of the issue is a potential version
> +mismatch between the version that root uses, and the version that the normal user
> +uses. On calling `ninja -C build`, it can't find the build.ninja module. This the snippet of error message,

Line wrap at 80 characters.

> +
> +:: 
> +
> +  ninja: Entering directory `build'     
> +  ninja: error: loading 'build.ninja': No such file or directory
> +
> +This can be solved in two ways: 
> +
> +1) Don't install meson again if it is already installed system-wide.
> +2) If meson which is different from system-wide is already installed, 

s/meson/a version of meson/

s/system-wide/the system-wide version/

> +uninstall that meson using pip3, and install again without the --user 
> +argument.
> \ No newline at end of file

There should be a newline at end of file.


The content and structure looks good! I think it's just style that's
left.


Paul

> -- 
> 2.25.1
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel