[libcamera-devel] [PATCH v5 06/17] libcamera: ipu3: Merge IPA metadata controls

[Kieran Bingham]

Hi Jacopo,

On 03/05/2021 11:41, Jacopo Mondi wrote:
> When a Request is completed upon receiving the IPA produced metadata,
> they should be merged with the metadata set by the pipeline handler
> before reporting them to applications.
> 
> Use ControlList::merge() to collect the IPA produced controls to the
> request's metadata.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Aha great, thank you - Good to have consistency here, even if we haven't
yet started adding metadata to this ipa.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
> index 88b7bd1e52c3..ade8ffbddb0e 100644
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> @@ -1190,11 +1190,8 @@ void IPU3CameraData::queueFrameAction(unsigned int id,
>  		if (!info)
>  			break;
>  
> -		/*
> -		 * \todo Parse the value of the controls returned by the IPA
> -		 * in action.controls to register additional metadata.
> -		 */
>  		Request *request = info->request;
> +		request->metadata().merge(action.controls);
>  
>  		info->metadataProcessed = true;
>  		if (frameInfos_.tryComplete(info))
> 

-- 
Regards
--
Kieran