[libcamera-devel] [PATCH v3 2/2] test: bayer-format: Rectify internal header's #include path

Sebastian Fricke sebastian.fricke at posteo.net
Wed May 5 10:07:20 CEST 2021


Hey Umang,

Thank you for the patch.

On 30.04.2021 10:09, Umang Jain wrote:
>libcamera internal headers are not available system-wide. Hence,
>directive `#include <libcamera/internal/header.h>` is wrong. Fix it
>by using "" for the #include directive.
>
>Fixes: e09c487b97f8 ("test: Add unit tests for the BayerFormat class")
>Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
Reviewed-by: Sebastian Fricke <sebastian.fricke at posteo.net>
>---
> test/bayer-format.cpp | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/test/bayer-format.cpp b/test/bayer-format.cpp
>index 047e7db3..e396ee83 100644
>--- a/test/bayer-format.cpp
>+++ b/test/bayer-format.cpp
>@@ -7,9 +7,10 @@
>
> #include <iostream>
>
>-#include <libcamera/internal/bayer_format.h>
> #include <libcamera/transform.h>
>
>+#include "libcamera/internal/bayer_format.h"
>+

This was my fault, thank you for fixing it!

> #include "test.h"
>
> using namespace std;
>-- 
>2.29.2
>
>_______________________________________________
>libcamera-devel mailing list
>libcamera-devel at lists.libcamera.org
>https://lists.libcamera.org/listinfo/libcamera-devel


More information about the libcamera-devel mailing list