[libcamera-devel] [PATCH] ipa: rpi: controller: Fix typo and improve comment

[Umang Jain]

Hi Sebastian,

On 5/2/21 3:35 PM, Sebastian Fricke wrote:
> Fix a typo ('for a collecting') within the comment, improve and simplify
> the comment.
>
> Signed-off-by: Sebastian Fricke <sebastian.fricke at posteo.net>
> ---
>   src/ipa/raspberrypi/controller/controller.hpp | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/ipa/raspberrypi/controller/controller.hpp b/src/ipa/raspberrypi/controller/controller.hpp
> index 49b1a551..910aeae1 100644
> --- a/src/ipa/raspberrypi/controller/controller.hpp
> +++ b/src/ipa/raspberrypi/controller/controller.hpp
> @@ -6,8 +6,8 @@
>    */
>   #pragma once
>   
> -// The Controller is simply a container for a collecting together a number of
> -// "control algorithms" (such as AWB etc.) and for running them all in a
> +// The Controller is simply a container, that collects a number of
> +// "control algorithms" (such as AWB etc.) and runs them all in a
This is already better, but for sake of complete-ness, maybe I will add

+// The Controller is simply a container, that collects a number of
+// "control algorithms" (such as AWB etc.) from the tuning file and runs them all in a


Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>
>   // convenient manner.
>   
>   #include <vector>