[libcamera-devel] [PATCH v5 08/17] libcamera: rkisp1: Do not over-write metadata

[Hirokazu Honda]

Hi Jacopo, thank you for the patch.

On Tue, May 4, 2021 at 5:12 PM Kieran Bingham <
kieran.bingham at ideasonboard.com> wrote:

> On 03/05/2021 11:41, Jacopo Mondi wrote:
> > When a Request is completed upon receiving the IPA produced metadata,
> > the metadata associated with the Request are over-written, deleting
> > the information set at output buffer completion, such as the
> > SensorTimestamp.
> >
> > This commit applies to the RkISP1 pipeline handler the same change
> > applied to IPU3 in commit 2ee3dd57e2fc ("libcamera: ipu3: Merge IPA
> > metadata controls").
> >
> > Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>
>
Reviewed-by: Hirokazu Honda <hiroh at chromium.org>


> > ---
> >  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > index c75666391222..26f708242523 100644
> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > @@ -365,7 +365,7 @@ void RkISP1CameraData::metadataReady(unsigned int
> frame, const ControlList &meta
> >       if (!info)
> >               return;
> >
> > -     info->request->metadata() = metadata;
> > +     info->request->metadata().merge(metadata);
> >       info->metadataProcessed = true;
> >
> >       pipe->tryCompleteRequest(info->request);
> >
>
> --
> Regards
> --
> Kieran
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20210506/c7713e02/attachment-0001.htm>