[libcamera-devel] [PATCH v2 7/7] libcamera: ipu3: imgu: Bump script version

[Hirokazu Honda]

Hi Jacopo, thank you for the patch.

On Mon, May 3, 2021 at 6:49 PM Laurent Pinchart <
laurent.pinchart at ideasonboard.com> wrote:

> Hi Jacopo,
>
> Thank you for the patch.
>
> On Mon, May 03, 2021 at 11:27:05AM +0200, Jacopo Mondi wrote:
> > Update the revision of the ImgU Python configuration tool the
> > libcamera implementation is based on to commit 243d134
> > ("Fix some bug for some resolutions").
> >
> > Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
>

Reviewed-by: Hirokazu Honda <hiroh at chromium.org>


> > ---
> >  src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp
> b/src/libcamera/pipeline/ipu3/imgu.cpp
> > index c874a07e8da6..b5143ef7ed8a 100644
> > --- a/src/libcamera/pipeline/ipu3/imgu.cpp
> > +++ b/src/libcamera/pipeline/ipu3/imgu.cpp
> > @@ -31,7 +31,7 @@ namespace {
> >   * The procedure to calculate the ImgU pipe configuration has been
> ported
> >   * from the pipe_config.py python script, available at:
> >   * https://github.com/intel/intel-ipu3-pipecfg
> > - * at revision: 61e83f2f7606 ("Add more information into README")
> > + * at revision: 243d134 ("Fix some bug for some resolutions")
>
> Nit-picking, the risk of collision is very low in this case, but 12
> digits commit IDs are usually preferred.
>
> I love the commit message summary by the way :-)
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>
>   */
> >
> >  static constexpr unsigned int FILTER_W = 4;
>
> --
> Regards,
>
> Laurent Pinchart
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20210506/dd768aec/attachment.htm>