[libcamera-devel] [PATCH 0/2] Remove V4L2Control classes

Hirokazu Honda hiroh at chromium.org
Fri May 7 04:17:25 CEST 2021


V4l2ControlId and V4L2ControlInfo has no additional member
variables or functions to ControlId and ControlInfo, and just
convenient classes to create ControlId and ControlInfo with
v4l2_query_ext_control. Therefore, they are unnecessary and
rather just introduce confusion. This patch series removes them.

Hirokazu Honda (2):
  libcamera: pipeline: Remove unnecessary v4l2_controls.h includes
  libcamera: V4L2Control: remove V4L2Control classes

 include/libcamera/internal/meson.build        |   1 -
 include/libcamera/internal/v4l2_controls.h    |  31 ----
 include/libcamera/internal/v4l2_device.h      |   4 +-
 src/libcamera/meson.build                     |   1 -
 src/libcamera/pipeline/ipu3/ipu3.cpp          |   1 -
 .../pipeline/raspberrypi/raspberrypi.cpp      |   1 -
 src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  |   1 -
 src/libcamera/pipeline/vimc/vimc.cpp          |   1 -
 src/libcamera/v4l2_controls.cpp               | 151 ------------------
 src/libcamera/v4l2_device.cpp                 |  72 ++++++++-
 10 files changed, 71 insertions(+), 193 deletions(-)
 delete mode 100644 include/libcamera/internal/v4l2_controls.h
 delete mode 100644 src/libcamera/v4l2_controls.cpp

--
2.31.1.607.g51e8a6a459-goog


More information about the libcamera-devel mailing list