[libcamera-devel] [PATCH 1/2] libcamera: pipeline: Remove unnecessary v4l2_controls.h includes

[Jacopo Mondi]

Hi Hiro,
  a shorter subject might be more appropriate :)

On Fri, May 07, 2021 at 11:17:26AM +0900, Hirokazu Honda wrote:
> v4l2_controls.h is includes in some places in pipeline codes.

includes->included

> But V4l2Control classes are not used there. This removes the
> redundant v4l2_controls.h includes.
>
> Signed-off-by: Hirokazu Honda <hiroh at chromium.org>

\o/

Happy to see leftovers gone. The minors in commit messages can be
changed when applying.

Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
   j

> ---
>  src/libcamera/pipeline/ipu3/ipu3.cpp               | 1 -
>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 1 -
>  src/libcamera/pipeline/uvcvideo/uvcvideo.cpp       | 1 -
>  src/libcamera/pipeline/vimc/vimc.cpp               | 1 -
>  4 files changed, 4 deletions(-)
>
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
> index 73306cea..e9fc41f4 100644
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> @@ -28,7 +28,6 @@
>  #include "libcamera/internal/media_device.h"
>  #include "libcamera/internal/pipeline_handler.h"
>  #include "libcamera/internal/utils.h"
> -#include "libcamera/internal/v4l2_controls.h"
>
>  #include "cio2.h"
>  #include "frames.h"
> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> index 2a917455..34d6044f 100644
> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> @@ -36,7 +36,6 @@
>  #include "libcamera/internal/media_device.h"
>  #include "libcamera/internal/pipeline_handler.h"
>  #include "libcamera/internal/utils.h"
> -#include "libcamera/internal/v4l2_controls.h"
>  #include "libcamera/internal/v4l2_videodevice.h"
>
>  #include "dma_heaps.h"
> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp
> index b6c6ade5..de1c36bf 100644
> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp
> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp
> @@ -25,7 +25,6 @@
>  #include "libcamera/internal/pipeline_handler.h"
>  #include "libcamera/internal/sysfs.h"
>  #include "libcamera/internal/utils.h"
> -#include "libcamera/internal/v4l2_controls.h"
>  #include "libcamera/internal/v4l2_videodevice.h"
>
>  namespace libcamera {
> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp
> index 8f5f4ba3..c242efa3 100644
> --- a/src/libcamera/pipeline/vimc/vimc.cpp
> +++ b/src/libcamera/pipeline/vimc/vimc.cpp
> @@ -30,7 +30,6 @@
>  #include "libcamera/internal/media_device.h"
>  #include "libcamera/internal/pipeline_handler.h"
>  #include "libcamera/internal/utils.h"
> -#include "libcamera/internal/v4l2_controls.h"
>  #include "libcamera/internal/v4l2_subdevice.h"
>  #include "libcamera/internal/v4l2_videodevice.h"
>
> --
> 2.31.1.607.g51e8a6a459-goog
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel