[libcamera-devel] [PATCH v2 5/7] ipa: ipu3: Introduce IPAConfigInfo in IPC

[Jacopo Mondi]

Hello,
   this all looks good, but I have a kind of unrelated question...

On Wed, May 19, 2021 at 03:49:52PM +0530, Umang Jain wrote:
> IPAConfigInfo is a consolidated data structure passed from IPU3
> pipeline-handler to IPU3 IPA. The structure can be extended with
> additional parameters to accommodate the requirements of multiple
> IPU3 IPA modules.
>
> Adapt the in-tree IPU3 IPA to use IPAConfigInfo as well.
>
> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

> ---
>  include/libcamera/ipa/ipu3.mojom     | 10 ++++++++--
>  src/ipa/ipu3/ipu3.cpp                | 14 ++++++--------
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 10 +++++++---
>  3 files changed, 21 insertions(+), 13 deletions(-)
>

[snip]

> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> @@ -633,9 +633,13 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)
>  		return ret;
>  	}
>
> -	std::map<uint32_t, ControlInfoMap> entityControls;
> -	entityControls.emplace(0, data->cio2_.sensor()->controls());
> -	data->ipa_->configure(entityControls, config->imguConfig().bds);
> +	ipa::ipu3::IPAConfigInfo configInfo;
> +	configInfo.entityControls.emplace(0, data->cio2_.sensor()->controls());
> +	configInfo.sensorInfo = sensorInfo;
> +	configInfo.bdsOutputSize = config->imguConfig().bds;
> +	configInfo.iif = config->imguConfig().iif;
> +
> +	data->ipa_->configure(configInfo);

Are we aware the if raw-only the function bails out earlier and the
ipa is never configured, right ?

Thanks
  j

>
>  	return 0;
>  }
> --
> 2.26.2
>