[libcamera-devel] [PATCH v6 4/5] android: camera_device: Get properties from configuration

[Laurent Pinchart]

On Sun, May 23, 2021 at 03:32:08AM +0300, Laurent Pinchart wrote:
> On Fri, May 21, 2021 at 05:56:41PM +0200, Jacopo Mondi wrote:
> > On Fri, May 21, 2021 at 03:41:10PM +0800, Han-lin Chen wrote:
> > > Hi Jacopo,
> > > Thanks for the efforts. The commits should be contained in 13971 and
> > > any later versions.
> > 
> > Great, thanks, I have now verified my series works on an
> > out-of-the-box image.
> > 
> > However the manifests for the SDK in manifest-version have not yet
> > catch up with the images and are stuck to R91. We'll have to wait
> > before merging the series for the right manifest to land, so we can
> > have both the image and the SDK at the same version.
> 
> Seems like it's available now. I'll kick off a build with
> full/buildspecs/92/13971.0.0-rc1.xml and report the results.

I had a build error in the chromeos-base/regions packages:

14:49:49 >>> Compiling source in /build/soraka-libcamera/tmp/portage/chromeos-base/regions-0.0.1-r2020/work/regions-0.0.1/regions ...
usage: regions.py [-h] [--format {human-readable,csv,json,yaml}] [--all] [--notes] [--include_pseudolocales] [--output OUTPUT] [--overlay OVERLAY]
regions.py: error: unrecognized arguments:

This was caused by the ebuild passing an empty argument to the
regions.py script (a `print(args)` in regions.py clearly shows this).
I've fixed it with the following patch.

diff --git a/chromeos-base/regions/regions-0.0.1-r2020.ebuild b/chromeos-base/regions/regions-0.0.1-r2020.ebuild
index 22684c2bf7e8..06b1a82f027c 100644
--- a/chromeos-base/regions/regions-0.0.1-r2020.ebuild
+++ b/chromeos-base/regions/regions-0.0.1-r2020.ebuild
@@ -31,7 +31,7 @@ src_unpack() {
 }

 src_compile() {
-	./regions.py --format=json --output "${WORKDIR}/cros-regions.json" "$(usex cros-debug "--include_pseudolocales" "")"
+	./regions.py --format=json --output "${WORKDIR}/cros-regions.json" $(usex cros-debug "--include_pseudolocales" "")
 }

 src_test() {

I'm curious, as the offending code was added in

commit a05940690157c100c902f41e8118400f2183eb3b
Author:     Matt Stark <msta at google.com>
AuthorDate: Mon Apr 19 11:16:04 2021 +1000
Commit:     Commit Bot <commit-bot at chromium.org>
CommitDate: Wed May 5 05:06:19 2021 +0000

    When creating a chrome OS debug build, add pseudolocales to the build.

which is more than two weeks old, and I would have expected the issue to
be caught. I can't see any fix in neither the chromeos-overlay (for the
build) nor the platform2 (for regions.py) main branches.

I can't rule out that it could be specific to my environment, as I
haven( recreated the SDK from scratch, I've removed the build directory
and updated the chroot with update_chroot.

Could anyone on the Chrome OS site which if they can reproduce this
issue when the cros-debug use flag isn't set ? I've added a comment to
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/2879390.

Other than that, the build is still ongoing, I'll report when it
completes.

> > > On Fri, May 21, 2021 at 3:29 PM Jacopo Mondi wrote:
> > > > On Fri, May 21, 2021 at 02:15:51PM +0900, Hirokazu Honda wrote:
> > > > > On Thu, Apr 15, 2021 at 10:51 PM Jacopo Mondi <jacopo at jmondi.org> wrote:
> > > > >
> > > > > > Open the HAL configuration file in the Camera HAL manager and get
> > > > > > the camera properties for each created CameraDevice and initialize it
> > > > > > with them.
> > > > > >
> > > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > > > >
> > > > > Reviewed-by: Hirokazu Honda <hiroh at chromium.org>
> > > > >
> > > > > When would you merge this series?
> > > >
> > > > My plan was to update my SDK to the latest version which contains the
> > > > CL to the libcamera and libcamera-configs ebuild, so I could have
> > > > tested one more time on a fresh image. Am I too paranoid ?
> > > >
> > > > Could you or Han-lin tell me which is the id of the first CPFE image
> > > > that contains:
> > > > https://chromium-review.googlesource.com/c/chromiumos/overlays/board-overlays/+/2887093
> > > > https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/2886535
> > > >
> > > > I've tested those patches applied on my rather ancient SDK version,
> > > > but I would like to try with an out-of-the-box image
> > > >
> > > > > > Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

-- 
Regards,

Laurent Pinchart