[libcamera-devel] [PATCH v3 0/6] External IPU3 IPA Support

[Laurent Pinchart]

Hi Umang,

Thank you for the series.

You're nearly there, I've only had minor comments. The corresponding
changes are however a bit too large for me to be comfortable with fixing
them when applying, so I'm afraid a v4 is needed. I'm quite sure it will
be the last one.

On Fri, May 21, 2021 at 06:58:17PM +0530, Umang Jain wrote:
> Changes in v3:
> - Drop 7/7 patch - decided to be done on top
> - Add a \todo about documenting IPA interfaces in [1/7]
> - Few style cleanups
> 
> Changes in v2:
> - IPA Docs rework patch split (into 3)
> - Don't try to make a different 'internal' helper library
>   - Drop relevant patch
>   - Under discussion for now AND out of scope for this series.
> - Drop IPAConfigInfo documentation
>   - Needs to happen during a follow up "doc" patch for entire ipu3.mojom
>     adapted same as [PATCH 2/7]
> 
> Umang Jain (6):
>   ipa: Move core IPA interface documentation to a .cpp file
>   ipa: mojom: Move CameraSensorInfo struct exclusively to IPA IPC
>   ipa: ipc: Rename CameraSensorInfo to IPACameraSensorInfo
>   ipa: meson: Install mojom generated headers to include paths
>   ipa: ipu3: Introduce IPAConfigInfo in IPC
>   meson: Add a configuration option to build IPAs
> 
>  Documentation/Doxyfile.in                     |   8 +-
>  Documentation/guides/ipa.rst                  |   8 +-
>  Documentation/meson.build                     |   1 +
>  include/libcamera/internal/camera_sensor.h    |  19 +-
>  include/libcamera/ipa/core.mojom              |  74 +-----
>  include/libcamera/ipa/ipa_interface.h         |   2 -
>  include/libcamera/ipa/ipu3.mojom              |  15 +-
>  include/libcamera/ipa/meson.build             |   8 +-
>  include/libcamera/ipa/raspberrypi.mojom       |   7 +-
>  include/libcamera/ipa/rkisp1.mojom            |   7 +-
>  include/libcamera/ipa/vimc.mojom              |   5 +
>  meson.build                                   |   1 +
>  meson_options.txt                             |   5 +
>  src/ipa/ipu3/ipu3.cpp                         |  14 +-
>  src/ipa/ipu3/ipu3_agc.cpp                     |   2 +-
>  src/ipa/meson.build                           |   5 +-
>  src/ipa/raspberrypi/raspberrypi.cpp           |   9 +-
>  src/ipa/rkisp1/rkisp1.cpp                     |   6 +-
>  src/libcamera/camera_sensor.cpp               | 117 +--------
>  src/libcamera/ipa/core_ipa_interface.cpp      | 237 ++++++++++++++++++
>  src/libcamera/ipa/meson.build                 |   5 +
>  src/libcamera/meson.build                     |   1 +
>  src/libcamera/pipeline/ipu3/ipu3.cpp          |  14 +-
>  .../pipeline/raspberrypi/raspberrypi.cpp      |   4 +-
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp      |   2 +-
>  25 files changed, 332 insertions(+), 244 deletions(-)
>  create mode 100644 src/libcamera/ipa/core_ipa_interface.cpp
>  create mode 100644 src/libcamera/ipa/meson.build
> 

-- 
Regards,

Laurent Pinchart