[libcamera-devel] [PATCH v4 1/3] controls: Split FrameDurations into FrameDuration and FrameDurationLimits

Jacopo Mondi jacopo at jmondi.org
Wed May 26 10:11:27 CEST 2021


Hi Paul,

On Wed, May 26, 2021 at 12:47:18PM +0900, Paul Elder wrote:
> We need a separate control to report the nominal frame duration, but
>
> -	controls[&controls::FrameDurations] = ControlInfo(frameDurations[0],
> -							  frameDurations[1],
> -							  frameDurations[2]);
> +	controls[&controls::FrameDurationLimits] =
> +		ControlInfo(frameDurations[0],
> +			    frameDurations[1],
> +			    frameDurations[2]);

That's a weird alignement :)
Whatever, I don't like going over 80 cols neither (but maybe the
ControlInfo(...) fits on one line now?)

Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
   j

>
>  	/*
>  	 * Compute the scaler crop limits.
> --
> 2.27.0
>


More information about the libcamera-devel mailing list