[libcamera-devel] [PATCH 1/2] android: camera_hal_config: Move include <filesystem> to .cpp file

Niklas Söderlund niklas.soderlund at ragnatech.se
Wed May 26 10:15:55 CEST 2021


Hi Laurent,

Thanks for your patch.

On 2021-05-26 03:08:54 +0300, Laurent Pinchart wrote:
> The <filesystem> header isn't needed in camera_hal_config.h, move its
> inclusion to camera_hal_config.cpp.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>

> ---
>  src/android/camera_hal_config.cpp | 1 +
>  src/android/camera_hal_config.h   | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp
> index 12d69a3f5f3c..d15df2e30c2c 100644
> --- a/src/android/camera_hal_config.cpp
> +++ b/src/android/camera_hal_config.cpp
> @@ -6,6 +6,7 @@
>   */
>  #include "camera_hal_config.h"
>  
> +#include <filesystem>
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <string>
> diff --git a/src/android/camera_hal_config.h b/src/android/camera_hal_config.h
> index 0555c6da2c20..97dc69c1def5 100644
> --- a/src/android/camera_hal_config.h
> +++ b/src/android/camera_hal_config.h
> @@ -7,7 +7,6 @@
>  #ifndef __ANDROID_CAMERA_HAL_CONFIG_H__
>  #define __ANDROID_CAMERA_HAL_CONFIG_H__
>  
> -#include <filesystem>
>  #include <map>
>  #include <string>
>  
> -- 
> Regards,
> 
> Laurent Pinchart
> 

-- 
Regards,
Niklas Söderlund


More information about the libcamera-devel mailing list