[libcamera-devel] [PATCH] ipa: ipu3: Rectify ControlInfoMap matching in IPAConfigInfo

[Laurent Pinchart]

Hi Umang,

Thank you for the patch.

On Wed, May 26, 2021 at 05:18:14PM +0530, Umang Jain wrote:
> The ControlInfoMap of entityControls member in IPAConfigInfo struct,
> was not able to correctly match to the ControlInfoMap defined in
> core.mojom. This resulted in a FATAL breakage when IPU3 IPA is meant to
> run:
> 
>  FATAL IPADataSerializer ipa_data_serializer.cpp:437 ControlSerializer
>  not provided for serialization of ControlInfoMap

Fixes: c76ca01323d8 ("ipa: ipu3: Introduce IPAConfigInfo in IPC")

> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

As this fixes a breakage in master, I'll merge it right away.

Paul, is there a way this issue could have been detected at compile time
? If that's not doable, could you send at least a documentation patch ?

> ---
>  include/libcamera/ipa/ipu3.mojom | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom
> index 6b6b431f..32c046ad 100644
> --- a/include/libcamera/ipa/ipu3.mojom
> +++ b/include/libcamera/ipa/ipu3.mojom
> @@ -32,7 +32,7 @@ struct IPU3Action {
>  
>  struct IPAConfigInfo {
>  	libcamera.IPACameraSensorInfo sensorInfo;
> -	map<uint32, ControlInfoMap> entityControls;
> +	map<uint32, libcamera.ControlInfoMap> entityControls;
>  	libcamera.Size bdsOutputSize;
>  	libcamera.Size iif;
>  };

-- 
Regards,

Laurent Pinchart