[libcamera-devel] [PATCH v2 4/5] meson: ipa: Pass core.mojom to the docs generator

[Umang Jain]

Hi Paul

On 5/26/21 7:00 PM, Umang Jain wrote:
> Hi Paul
>
> On 5/25/21 3:22 PM, Paul Elder wrote:
>> We don't want to generate the same functional files for core.mojom as
>> the other mojom files, but we do want to generate the documentation cpp
>> files. Add core.mojom to the mojom files list after the main generation
>> is complete, so that the documentation generator can pick it up.
>>
>> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
>> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>> ---
>>   include/libcamera/ipa/meson.build | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/include/libcamera/ipa/meson.build 
>> b/include/libcamera/ipa/meson.build
>> index 729483ab..81fb69f0 100644
>> --- a/include/libcamera/ipa/meson.build
>> +++ b/include/libcamera/ipa/meson.build
>> @@ -145,3 +145,6 @@ foreach file : ipa_mojom_files
>>   endforeach
>>     ipa_mojom_files = files(ipa_mojom_files)
>> +
>> +# Pass this to the documentation generator in src/libcamera/ipa
>> +ipa_mojom_files += files(['core.mojom'])
> nitpick: I would setup this as:
>
> ipa_mojom_files += files([
>     'core.mojom',
> ])
Didn't realize it's only core.mojom :S, Looks good as per the patch.
>
> Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>
>