[libcamera-devel] [PATCH] libcamera: add OV5693 sensor properties

[Laurent Pinchart]

Hi Tomasz,

On Thu, May 27, 2021 at 04:02:06PM +0900, Tomasz Figa wrote:
> On Tue, May 25, 2021 at 7:37 PM Jacopo Mondi <jacopo at jmondi.org> wrote:
> > On Tue, May 25, 2021 at 07:56:14AM +0200, jeanmichel.hautbois at ideasonboard.com wrote:
> > > From: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>
> > >
> > > The new sensor database has introduced several sensors, but ov5693 is
> > > missing.
> > > It is used on most MS Surface tablets, add it to the database.
> > >
> > > Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>
> > > ---
> > >  src/libcamera/camera_sensor_properties.cpp | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
> > > index 6ded31dc..2a6e97f7 100644
> > > --- a/src/libcamera/camera_sensor_properties.cpp
> > > +++ b/src/libcamera/camera_sensor_properties.cpp
> > > @@ -54,6 +54,9 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
> > >               { "ov13858", {
> > >                       .unitCellSize = { 1120, 1120 },
> > >               } },
> > > +             { "ov5693", {
> > > +                     .unitCellSize = { 1400, 1400 },
> >
> > Don't have a datasheet to very, so I assume that's correct!
> >
> > Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>
> 
> I don't see a driver for this sensor in the kernel tree yet. I assume
> that this patch will wait until the driver is merged?

The driver has been developed by the linux-surface community
(https://github.com/linux-surface) and is on its way to upstream, so I'm
fine with supporting it in libcamera already. Overall, if there's no
reason to distrust the upstreaming effort, I don't see a reason to wait
until the patches have been merged upstream.

-- 
Regards,

Laurent Pinchart