[libcamera-devel] [PATCH] libcamera: Add libcamera_generated_ipa_headers as a dependency for libcamera_dep

[Laurent Pinchart]

Hello,

On Fri, May 28, 2021 at 07:52:43PM +0530, Umang Jain wrote:
> On 5/28/21 6:48 PM, Niklas Söderlund wrote:
> > Some external components such as the unit tests include headers
> > generated for the IPA's. This is not fully described in meson for each
> > external component which results in one or more races in the build
> > system. Instead of playing wack-a-mole add the generated IPA headers to

s/wack/whack/ otherwise it will have a different meaning :-)

> > libcamera_dep.
> >
> > Suggested-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > Signed-off-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
> > ---
> >   src/libcamera/meson.build | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >
> > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
> > index cc2b8669d1d9900a..ca67a783356c930f 100644
> > --- a/src/libcamera/meson.build
> > +++ b/src/libcamera/meson.build
> > @@ -155,9 +155,16 @@ libcamera = shared_library('camera',
> >                              build_rpath : '/',
> >                              dependencies : libcamera_deps)
> >   
> > +# TODO Drop libcamera_generated_ipa_headers from libcamera_dep as libcamera_dep
> > +# is supposed to model the dependencies required for usage of the public API,
> > +# not the internal API. It is needed as as some extenral components such as the
>
> s/extenral/external/
> 
> This is one more use-case I can see, when we visit the requirement of 
> exposing some of libcamera "internal" headers to system at-large, in 
> some way. The requirement has popped up with recent Intel IPU3 IPA 
> living out-of-tree but using some of internal headers. I guess, there 
> will be substantial overlap with tests using the internal APIs as well, 
> that can be benefitted from whatever we can come up with.

Note that the tests are meant to test, well, everything, so they won't
be limited to using the utils library we'll split out from the main
libcamera.so in the future.

> > +# unit tests make use of the generated headers and this creates a race in the
> > +# build.
> > +
> >   libcamera_dep = declare_dependency(sources : [
> >                                          libcamera_ipa_headers,
> >                                          libcamera_public_headers,
> > +                                       libcamera_generated_ipa_headers,
> >                                      ],
> >                                      include_directories : libcamera_includes,
> >                                      link_with : libcamera)
>
> Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

-- 
Regards,

Laurent Pinchart