[libcamera-devel] [PATCH 1/3] pipeline: raspberrypi: Add const qualifer in isRaw()

Kieran Bingham kieran.bingham at ideasonboard.com
Wed Nov 10 11:16:07 CET 2021


Quoting Naushir Patuck (2021-11-10 10:08:00)
> This function does not modify the pixFmt parameter, so use a const qualifier.
> 
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> index 5e1f227398a9..11d3c2b120dd 100644
> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> @@ -96,7 +96,7 @@ V4L2DeviceFormat toV4L2DeviceFormat(const V4L2SubdeviceFormat &format,
>         return deviceFormat;
>  }
>  
> -bool isRaw(PixelFormat &pixFmt)
> +bool isRaw(const PixelFormat &pixFmt)
>  {
>         /*
>          * The isRaw test might be redundant right now the pipeline handler only
> -- 
> 2.25.1
>


More information about the libcamera-devel mailing list