[libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Fix minCrop indentation

[Jacopo Mondi]

Hi Kieran,

On Wed, Nov 10, 2021 at 11:33:41PM +0000, Kieran Bingham wrote:
> When updating the controls the calculation for minCrop incorrectly
> indents the parameters to scaledBy().
>
> Fix it.
>
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Ups,
Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
   j

> ---
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
> index eb714aa61099..3cd7383f0e40 100644
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> @@ -1039,7 +1039,7 @@ int PipelineHandlerIPU3::updateControls(IPU3CameraData *data)
>  	 * top-left corner as we allow application to freely pan the crop area.
>  	 */
>  	Rectangle minCrop = Rectangle(minSize).scaledBy(analogueCrop.size(),
> -					       sensorInfo.outputSize);
> +							sensorInfo.outputSize);
>
>  	controls[&controls::ScalerCrop] = ControlInfo(minCrop, maxCrop, maxCrop);
>
> --
> 2.30.2
>