[libcamera-devel] [PATCH v4 12/14] ipa: ipu3: Cache line duration at configure call

[Kieran Bingham]

Quoting Jean-Michel Hautbois (2021-11-12 16:44:08)
> 
> 
> On 12/11/2021 17:19, Kieran Bingham wrote:
> > Quoting Jean-Michel Hautbois (2021-11-12 16:03:53)
> >> Hi Kieran,
> >>
> >> On 12/11/2021 14:21, Kieran Bingham wrote:
> >>> Quoting Umang Jain (2021-11-12 12:36:21)
> >>>> Hi JM,
> >>>>
> >>>> On 11/11/21 7:39 PM, Jean-Michel Hautbois wrote:
> >>>>> We use the line duration several times in the IPAIPU3. Instead of
> >>>>> recalculating it each time, cache the value as a utils::Duration. When
> >>>>> the value is needed, cast it to a std::micro value.
> >>>
> >>> Aren't values always 'needed' when they're obtained? This isn't quite
> >>> helping improve the clarity.
> >>>
> >>> Why is it needed in micros, vs other usages?
> >>
> >> OK, I may have to specify it is documented in
> >> src/libcamera/control_ids.yaml ?
> >>
> >> '''
> >> - ExposureTime:
> >>       type: int32_t
> >>       description: |
> >> Exposure time (shutter speed) for the frame applied in the sensor
> >> device. This value is specified in micro-seconds.
> >> '''
> >>
> >> How can I reference this file in the commit message ?
> > 
> > I don't think you need to reference the file, just the fact that
> > ExposureTime and FrameDuration units are in micro-seconds, and so the
> > Duration is cast accordingly.
> 
> Thanks,
> 
> '''
> We use the line duration several times in the IPAIPU3. Instead of
> recalculating it each time, cache the value as a utils::Duration.
> ExposureTime and FrameDuration units are in micro-seconds, cast the
> Duration accordingly.
> 
> As sensorInfo is no longer used in updateSessionConfiguration remove the
> reference to it.
> '''

Works for me!

Thanks,
Kieran