[libcamera-devel] [PATCH v2 2/2] android: Introduce PlatformFrameBufferAllocator

[Kieran Bingham]

Quoting Hirokazu Honda (2021-11-10 03:09:34)
> Hi Kieran,
> 
> > In fact, it doesn't matter too much - but I still don't see why this
> > needs to be Extensible.
> >
> > The implementation for PlatformFrameBufferAllocator can have an
> > identically named class in both
> >         src/android/mm/cros_frame_buffer_allocator.cpp
> >         src/android/mm/generic_frame_buffer_allocator.cpp
> >
> > And the one that gets used will be the one that is compiled in...?
> >
> 
> That's a good point. I couldn't find a reason for this.
> If this is applicable for PlatformFrameBufferAllocator, I think we can
> change CameraBuffer too.

Sure, if it simplifies things. The class is not a public API, and
doesn't need to be 'extensible' with a private implementation as far as
I am aware. In this case, it's just that there are two possible
implementations which are selected at compile time anyway.

--
Kieran