[libcamera-devel] [PATCH 2/2] libipa: Correct IMX219 in CameraSensorHelper

Jean-Michel Hautbois jeanmichel.hautbois at ideasonboard.com
Fri Nov 19 11:25:59 CET 2021


The equation is badly reported in the CameraSensorHelper, as m1 and c0
are inverted. Correct it to have a proper gain calculation.

Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>
---
 src/ipa/libipa/camera_sensor_helper.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
index 67cf6913..5e22f9c3 100644
--- a/src/ipa/libipa/camera_sensor_helper.cpp
+++ b/src/ipa/libipa/camera_sensor_helper.cpp
@@ -292,7 +292,7 @@ class CameraSensorHelperImx219 : public CameraSensorHelper
 public:
 	CameraSensorHelperImx219()
 	{
-		analogueGainConstants_ = { AnalogueGainLinear, 0, -1, 256, 256 };
+		analogueGainConstants_ = { AnalogueGainLinear, 0, 256, -1, 256 };
 	}
 };
 REGISTER_CAMERA_SENSOR_HELPER("imx219", CameraSensorHelperImx219)
-- 
2.32.0



More information about the libcamera-devel mailing list