[libcamera-devel] [PATCH] ipa: ipu3: Fix IPAContext documentation

Kieran Bingham kieran.bingham at ideasonboard.com
Fri Nov 19 11:58:52 CET 2021


Quoting Jean-Michel Hautbois (2021-11-19 10:22:19)
> The shutter speed limits and analogue gains limits are in the agc
> structure in IPASessionConfiguration. They are badly mentionned as

/mentionned/mentioned/

> beeing part of the grid structure, fix it.

/beeing/being/


Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> 
> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>
> ---
>  src/ipa/ipu3/ipa_context.cpp | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp
> index 99caf9ad..86794ac1 100644
> --- a/src/ipa/ipu3/ipa_context.cpp
> +++ b/src/ipa/ipu3/ipa_context.cpp
> @@ -76,13 +76,13 @@ namespace libcamera::ipa::ipu3 {
>   * \var IPASessionConfiguration::agc.minShutterSpeed
>   * \brief Minimum shutter speed supported with the configured sensor
>   *
> - * \var IPASessionConfiguration::grid.maxShutterSpeed
> + * \var IPASessionConfiguration::agc.maxShutterSpeed
>   * \brief Maximum shutter speed supported with the configured sensor
>   *
> - * \var IPASessionConfiguration::grid.minAnalogueGain
> + * \var IPASessionConfiguration::agc.minAnalogueGain
>   * \brief Minimum analogue gain supported with the configured sensor
>   *
> - * \var IPASessionConfiguration::grid.maxAnalogueGain
> + * \var IPASessionConfiguration::agc.maxAnalogueGain
>   * \brief Maximum analogue gain supported with the configured sensor
>   */
>  
> -- 
> 2.32.0
>


More information about the libcamera-devel mailing list