[libcamera-devel] [PATCH v2 12/12] libcamera: Add tracing to meson summary

[Laurent Pinchart]

Hi Jacopo,

Thank you for the patch.

On Sat, Nov 20, 2021 at 12:13:13PM +0100, Jacopo Mondi wrote:
> The meson option summary currently does not report if the support
> for tracing is enabled or not. Add it.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>  meson.build               | 1 +
>  src/libcamera/meson.build | 3 +++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/meson.build b/meson.build
> index 7892a9e38c1c..15793e1834ce 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -179,6 +179,7 @@ summary({
>              'qcam application': qcam_enabled,
>              'lc-compliance application': lc_compliance_enabled,
>              'Unit tests': test_enabled,
> +            'Tracing support': tracing_enabled,

I'd move this after "Enabled IPA modules" to group it with the features
of the libcamera core.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

>          },
>          section : 'Configuration',
>          bool_yn : true)
> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
> index 6fb0d5f49b63..6a3f5160fdcd 100644
> --- a/src/libcamera/meson.build
> +++ b/src/libcamera/meson.build
> @@ -71,8 +71,11 @@ if libgnutls.found()
>  endif
>  
>  if liblttng.found()
> +    tracing_enabled = true
>      config_h.set('HAVE_TRACING', 1)
>      libcamera_sources += files(['tracepoints.cpp'])
> +else
> +    tracing_enabled = false
>  endif
>  
>  if libudev.found()

-- 
Regards,

Laurent Pinchart