[libcamera-devel] [PATCH 04/15] libcamera: ipa: Convert to pragma once

Kieran Bingham kieran.bingham at ideasonboard.com
Tue Nov 23 23:40:04 CET 2021


Remove the verbose #ifndef/#define/#endif pattern for maintaining
header idempotency, and replace it with a simple #pragma once.

This simplifies the headers, and prevents redundant changes when
header files get moved.

Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
 include/libcamera/ipa/ipa_controls.h    | 6 ++----
 include/libcamera/ipa/ipa_interface.h   | 6 ++----
 include/libcamera/ipa/ipa_module_info.h | 6 ++----
 include/libcamera/ipa/raspberrypi.h     | 6 ++----
 4 files changed, 8 insertions(+), 16 deletions(-)

diff --git a/include/libcamera/ipa/ipa_controls.h b/include/libcamera/ipa/ipa_controls.h
index eec34d9267af..da1a759618e0 100644
--- a/include/libcamera/ipa/ipa_controls.h
+++ b/include/libcamera/ipa/ipa_controls.h
@@ -4,8 +4,8 @@
  *
  * ipa_controls.h - IPA Control handling
  */
-#ifndef __LIBCAMERA_IPA_CONTROLS_H__
-#define __LIBCAMERA_IPA_CONTROLS_H__
+
+#pragma once
 
 #include <stdint.h>
 
@@ -50,5 +50,3 @@ struct ipa_control_info_entry {
 #ifdef __cplusplus
 }
 #endif
-
-#endif /* __LIBCAMERA_IPA_CONTROLS_H__ */
diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h
index 1590584c1fb4..50ca0e7b0359 100644
--- a/include/libcamera/ipa/ipa_interface.h
+++ b/include/libcamera/ipa/ipa_interface.h
@@ -4,8 +4,8 @@
  *
  * ipa_interface.h - Image Processing Algorithm interface
  */
-#ifndef __LIBCAMERA_IPA_INTERFACE_H__
-#define __LIBCAMERA_IPA_INTERFACE_H__
+
+#pragma once
 
 #include <stddef.h>
 #include <stdint.h>
@@ -37,5 +37,3 @@ public:
 extern "C" {
 libcamera::IPAInterface *ipaCreate();
 }
-
-#endif /* __LIBCAMERA_IPA_INTERFACE_H__ */
diff --git a/include/libcamera/ipa/ipa_module_info.h b/include/libcamera/ipa/ipa_module_info.h
index 3b1c37d2a7f1..b19b00f71a9b 100644
--- a/include/libcamera/ipa/ipa_module_info.h
+++ b/include/libcamera/ipa/ipa_module_info.h
@@ -4,8 +4,8 @@
  *
  * ipa_module_info.h - Image Processing Algorithm module information
  */
-#ifndef __LIBCAMERA_IPA_MODULE_INFO_H__
-#define __LIBCAMERA_IPA_MODULE_INFO_H__
+
+#pragma once
 
 #include <stdint.h>
 
@@ -25,5 +25,3 @@ extern const struct IPAModuleInfo ipaModuleInfo;
 }
 
 } /* namespace libcamera */
-
-#endif /* __LIBCAMERA_IPA_MODULE_INFO_H__ */
diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h
index 521eaecd19b2..7f705e49411d 100644
--- a/include/libcamera/ipa/raspberrypi.h
+++ b/include/libcamera/ipa/raspberrypi.h
@@ -4,8 +4,8 @@
  *
  * raspberrypi.h - Image Processing Algorithm interface for Raspberry Pi
  */
-#ifndef __LIBCAMERA_IPA_INTERFACE_RASPBERRYPI_H__
-#define __LIBCAMERA_IPA_INTERFACE_RASPBERRYPI_H__
+
+#pragma once
 
 #include <stdint.h>
 
@@ -53,5 +53,3 @@ static const ControlInfoMap Controls({
 } /* namespace libcamera */
 
 #endif /* __DOXYGEN__ */
-
-#endif /* __LIBCAMERA_IPA_INTERFACE_RASPBERRYPI_H__ */
-- 
2.30.2



More information about the libcamera-devel mailing list