[libcamera-devel] [PATCH v4 1/4] ipa: ipu3: Extend ipu3 ipa interface for lens controls

[Laurent Pinchart]

Hi Han-lin,

Thank you for the patch.

On Tue, Nov 23, 2021 at 08:37:48PM +0800, Han-Lin Chen wrote:
> IPU3Event and IPU3Action use two fields for both libcamera controls and sensor
> V4L2 controls. The patch extend one more field for lens V4L2 controls
> for auto focus usage.
> 
> Signed-off-by: Han-Lin Chen <hanlinchen at chromium.org>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
>  include/libcamera/ipa/ipu3.mojom | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom
> index 16e3462e..cc0d822f 100644
> --- a/include/libcamera/ipa/ipu3.mojom
> +++ b/include/libcamera/ipa/ipu3.mojom
> @@ -24,12 +24,14 @@ struct IPU3Event {
>  	uint32 bufferId;
>  	libcamera.ControlList controls;
>  	libcamera.ControlList sensorControls;
> +	libcamera.ControlList lensControls;

I'd like to investigate if we should create internal controls for the
sensor and lens, that could be combined in a single control list, and
translated to V4L2 controls in the appropriate classes. For now this
should be good enough.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

>  };
>  
>  struct IPU3Action {
>  	IPU3Operations op;
>  	libcamera.ControlList controls;
>  	libcamera.ControlList sensorControls;
> +	libcamera.ControlList lensControls;
>  };
>  
>  struct IPAConfigInfo {

-- 
Regards,

Laurent Pinchart