[libcamera-devel] [PATCH] android: camera_device: Provide toString() helper for stream_type

[Kieran Bingham]

Quoting Umang Jain (2021-11-25 08:05:18)
> Provide a directionToString() helper to return a human-friendly name
> for camera3_stream_t->stream_type. Replace the int value being printed
> in configureStreams() INFO log with directionToString().
> 

Great, Human readable is so much better.


> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
> ---
>  src/android/camera_device.cpp | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> index f2e0bdbd..804a71fd 100644
> --- a/src/android/camera_device.cpp
> +++ b/src/android/camera_device.cpp
> @@ -175,6 +175,20 @@ const char *rotationToString(int rotation)
>         return "INVALID";
>  }
>  
> +const char *directionToString(int stream_type)
> +{
> +       switch (stream_type) {
> +       case CAMERA3_STREAM_OUTPUT:
> +               return "Output";
> +       case CAMERA3_STREAM_INPUT:
> +               return "Input";
> +       case CAMERA3_STREAM_BIDIRECTIONAL:
> +               return "Bidirectional";
> +       }
> +
> +       return "Unknown";
> +}
> +
>  #if defined(OS_CHROMEOS)
>  /*
>   * Check whether the crop_rotate_scale_degrees values for all streams in
> @@ -548,7 +562,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)
>                 PixelFormat format = capabilities_.toPixelFormat(stream->format);
>  
>                 LOG(HAL, Info) << "Stream #" << i
> -                              << ", direction: " << stream->stream_type
> +                              << ", direction: " << directionToString(stream->stream_type)
>                                << ", width: " << stream->width
>                                << ", height: " << stream->height
>                                << ", format: " << utils::hex(stream->format)

Is this one possible too? (Format?)


Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> -- 
> 2.31.0
>