[libcamera-devel] [PATCH 1/7] android: camera_capabilities: Add messages for lack of FULL support

[Kieran Bingham]

Quoting Paul Elder (2021-11-23 10:40:36)
> Print messages when some feature is missing that causes hardware level
> FULL to not be supported.
> 
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> ---
>  src/android/camera_capabilities.cpp | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp
> index f357902e..8c138df4 100644
> --- a/src/android/camera_capabilities.cpp
> +++ b/src/android/camera_capabilities.cpp
> @@ -359,6 +359,9 @@ void CameraCapabilities::computeHwLevel(
>  {
>         camera_metadata_ro_entry_t entry;
>         bool found;
> +
> +       const char *noFull = "Hardware level FULL unavailable: ";
> +
>         camera_metadata_enum_android_info_supported_hardware_level
>                 hwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_FULL;
>  
> @@ -372,8 +375,10 @@ void CameraCapabilities::computeHwLevel(
>                 hwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED;
>  
>         found = staticMetadata_->getEntry(ANDROID_SYNC_MAX_LATENCY, &entry);
> -       if (!found || *entry.data.i32 != 0)
> +       if (!found || *entry.data.i32 != 0) {
> +               LOG(HAL, Info) << noFull << "missing or invalid max sync latency";
>                 hwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED;
> +       }

Are the other settings that force _LIMITED affected? Or are the all the
'real' times when _LIMITED is expected.


Should it only print if hwLevel is not already set to
ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED by one of the statements
above?

Otherwise if it's a missing feature on a target that expects to be
limited it would be noisy.

If we always want to print it, I'd move it below the if (!found) to it's
own statement otherwise.

--
Kieran


>  
>         hwLevel_ = hwLevel;
>  }
> -- 
> 2.27.0
>