[libcamera-devel] [PATCH 2/7] android: camera_capabilities: Set read sensor settings capability

Kieran Bingham kieran.bingham at ideasonboard.com
Thu Nov 25 12:02:43 CET 2021


Quoting Paul Elder (2021-11-23 10:40:37)
> A libcamera camera that supports the manual sensor capability also
> satisfies all the requirements for the read sensor settings capability.
> Set it.

Ok ;-)

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> ---
>  src/android/camera_capabilities.cpp | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp
> index 8c138df4..8484c682 100644
> --- a/src/android/camera_capabilities.cpp
> +++ b/src/android/camera_capabilities.cpp
> @@ -339,8 +339,11 @@ CameraCapabilities::computeCapabilities()
>  
>         capabilities.insert(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE);
>  
> -       if (validateManualSensorCapability())
> +       if (validateManualSensorCapability()) {
>                 capabilities.insert(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR);
> +               /* The libcamera requirements cover this */
> +               capabilities.insert(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_READ_SENSOR_SETTINGS);
> +       }
>  
>         if (validateManualPostProcessingCapability())
>                 capabilities.insert(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_POST_PROCESSING);
> -- 
> 2.27.0
>


More information about the libcamera-devel mailing list