[libcamera-devel] [PATCH v2 00/11] Introduce clang thread safety annotations
Hirokazu Honda
hiroh at chromium.org
Mon Nov 29 12:44:42 CET 2021
This introduces clang thread safety annotations and applies it
to libcamera Android HAL adaptation layer. It is necessary to add
new classes that wrap std::mutex, std::unique_lock and
std::condition_variable with the annotations. It is because no
C++ standard library annotates all the mutex classes today.
libstdc++ doesn't annotate any classes. libc++ annotates for
std::mutex, std::lock_guard and std::scoped_lock, but doesn't for
std::unique_lock.
Therefore it is possible to use std::mutex if libc++ is used.
Althoug I don't do so In this patch series because the existing
code using std::mutex is not annotated yet.
Document: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html
Change in v2:
- Introduce ConditionVariable
- Consolidate std::mutex/std::unique_lock and Mutex/MutexLocker
- Replace Mutx and MutexLocker with new classes, not having
duplicated classes
- Separate code fix patches from thread annotation patches
Hirokazu Honda (11):
libcamera: base: Introduce ConditionVariable
android: Consolidate mutex classes to Mutex and MutexLocker
v4l2: Consolidate mutex classes to Mutex and MutexLocker
libcamera: base: Add thread safety annotation macros
libcamera: base: Add mutex classes with thread safety annotations
android: camera_hal_manager: Add thread safety annotation
android: camera_stream: Protect buffers initialization by mutex_
android: camera_stream: Add thread safety annotation
android: camera_device: Fix variables access without protection
android: camera_device: Add thread safety annotation
android: camera_request: Add thread safety annotation
include/libcamera/base/meson.build | 2 +
include/libcamera/base/mutex.h | 127 ++++++++++++++++++++
include/libcamera/base/semaphore.h | 4 +-
include/libcamera/base/thread.h | 5 +-
include/libcamera/base/thread_annotations.h | 80 ++++++++++++
meson.build | 1 +
src/android/camera_device.cpp | 10 +-
src/android/camera_device.h | 18 +--
src/android/camera_hal_manager.h | 14 +--
src/android/camera_request.h | 8 +-
src/android/camera_stream.cpp | 15 +--
src/android/camera_stream.h | 16 +--
src/libcamera/base/thread.cpp | 3 +-
src/libcamera/camera_manager.cpp | 3 +-
src/v4l2/v4l2_camera.h | 4 +-
src/v4l2/v4l2_camera_proxy.cpp | 8 +-
src/v4l2/v4l2_camera_proxy.h | 5 +-
17 files changed, 269 insertions(+), 54 deletions(-)
create mode 100644 include/libcamera/base/mutex.h
create mode 100644 include/libcamera/base/thread_annotations.h
--
2.34.0.rc2.393.gf8c9666880-goog
More information about the libcamera-devel
mailing list