[libcamera-devel] [PATCH] ipu3: ipa: Report correct exposure in request metadata

[Jean-Michel Hautbois]

Hi Umang,

Thanks for the patch !

On 29/11/2021 18:10, Umang Jain wrote:
> While populating the ControlList for the request's metadata,
> the exposure value should be used computed from AGC algorithm
> instead of sensor's exposure.
> 
> The issue is caught while debugging a FULL-level CTS test.
> 
> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>

Sounds like a bug indeed :-).
Reviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>

> ---
>   src/ipa/ipu3/ipu3.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
> index a8d54a5d..9cd80a02 100644
> --- a/src/ipa/ipu3/ipu3.cpp
> +++ b/src/ipa/ipu3/ipu3.cpp
> @@ -632,7 +632,7 @@ void IPAIPU3::parseStatistics(unsigned int frame,
>   
>   	ctrls.set(controls::ColourTemperature, context_.frameContext.awb.temperatureK);
>   
> -	ctrls.set(controls::ExposureTime, context_.frameContext.sensor.exposure * lineDuration_.get<std::micro>());
> +	ctrls.set(controls::ExposureTime, context_.frameContext.agc.exposure * lineDuration_.get<std::micro>());
>   
>   	/*
>   	 * \todo The Metadata provides a path to getting extended data
>