[libcamera-devel] [PATCH v5 1/4] ipa: ipu3: Extend ipu3 ipa interface for lens controls

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Nov 30 04:52:51 CET 2021


Hi Han-lin,

Thank you for the patch.

On Fri, Nov 26, 2021 at 07:29:00PM +0800, Han-Lin Chen wrote:
> IPU3Event and IPU3Action use two fields for both libcamera controls and sensor
> V4L2 controls. The patch extend one more field for lens V4L2 controls
> for auto focus usage.
> 
> Signed-off-by: Han-Lin Chen <hanlinchen at chromium.org>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  include/libcamera/ipa/ipu3.mojom | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom
> index 16e3462e..cc0d822f 100644
> --- a/include/libcamera/ipa/ipu3.mojom
> +++ b/include/libcamera/ipa/ipu3.mojom
> @@ -24,12 +24,14 @@ struct IPU3Event {
>  	uint32 bufferId;
>  	libcamera.ControlList controls;
>  	libcamera.ControlList sensorControls;
> +	libcamera.ControlList lensControls;
>  };
>  
>  struct IPU3Action {
>  	IPU3Operations op;
>  	libcamera.ControlList controls;
>  	libcamera.ControlList sensorControls;
> +	libcamera.ControlList lensControls;
>  };
>  
>  struct IPAConfigInfo {

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list