[libcamera-devel] [PATCH] ipa: rkisp1: Initialize numCells in constructor

[Umang Jain]

Hi JM,

On 11/30/21 12:15 PM, Jean-Michel Hautbois wrote:
> The non-static class member "numCells_" is not initialized in the
> constructor, leading to a coverity scan report (UNINIT_CTOR).
>
> Fix it.


Usually we should also mention the report as per:

     $ git log --grep=Coverity | grep CID

     Reported-by: Coverity CID=361652
     Reported-by: Coverity CID=354657
     ...


Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>

> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>
> ---
>   src/ipa/rkisp1/algorithms/agc.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp
> index 650fe2dae..d6abdc310 100644
> --- a/src/ipa/rkisp1/algorithms/agc.cpp
> +++ b/src/ipa/rkisp1/algorithms/agc.cpp
> @@ -53,7 +53,7 @@ static constexpr uint32_t kNumStartupFrames = 10;
>   static constexpr double kRelativeLuminanceTarget = 0.4;
>   
>   Agc::Agc()
> -	: frameCount_(0), filteredExposure_(0s)
> +	: frameCount_(0), numCells_(0), filteredExposure_(0s)
>   {
>   }
>