[libcamera-devel] [PATCH] ipa: ipu3: Rectify gain value reporting in request metadata

[Jean-Michel Hautbois]

Hi Umang,

On 30/11/2021 06:22, Umang Jain wrote:
> Report value of sensor's gain pertaining to the current request
> completion, as that is the gain value the request completed with.
> The Agc algorithm processes the gain value for incoming next request
> hence it should not be reported in request's metadata.
> 
> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>

Thanks for the explanation in previous patch.
Reviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>

> ---
>   src/ipa/ipu3/ipu3.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
> index b0c75541..76182587 100644
> --- a/src/ipa/ipu3/ipu3.cpp
> +++ b/src/ipa/ipu3/ipu3.cpp
> @@ -628,7 +628,7 @@ void IPAIPU3::parseStatistics(unsigned int frame,
>   	int64_t frameDuration = (defVBlank_ + sensorInfo_.outputSize.height) * lineDuration_.get<std::micro>();
>   	ctrls.set(controls::FrameDuration, frameDuration);
>   
> -	ctrls.set(controls::AnalogueGain, context_.frameContext.agc.gain);
> +	ctrls.set(controls::AnalogueGain, context_.frameContext.sensor.gain);
>   
>   	ctrls.set(controls::ColourTemperature, context_.frameContext.awb.temperatureK);
>   
>