[libcamera-devel] [RFC PATCH 2/6] cam: Remove using namespace in stream_options.h

Hirokazu Honda hiroh at chromium.org
Tue Oct 5 09:31:10 CEST 2021


"using namespace" in a header file propagates the namespace to
the files including the header file. So it should be avoided.
This removes "using namespace" in stream_options.h

Signed-off-by: Hirokazu Honda <hiroh at chromium.org>
---
 src/cam/stream_options.h | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/cam/stream_options.h b/src/cam/stream_options.h
index 577391f0..fbbc13a3 100644
--- a/src/cam/stream_options.h
+++ b/src/cam/stream_options.h
@@ -11,8 +11,6 @@
 
 #include "options.h"
 
-using namespace libcamera;
-
 class StreamKeyValueParser : public KeyValueParser
 {
 public:
@@ -20,12 +18,12 @@ public:
 
 	KeyValueParser::Options parse(const char *arguments) override;
 
-	static StreamRoles roles(const OptionValue &values);
-	static int updateConfiguration(CameraConfiguration *config,
+	static libcamera::StreamRoles roles(const OptionValue &values);
+	static int updateConfiguration(libcamera::CameraConfiguration *config,
 				       const OptionValue &values);
 
 private:
-	static bool parseRole(StreamRole *role,
+	static bool parseRole(libcamera::StreamRole *role,
 			      const KeyValueParser::Options &options);
 };
 
-- 
2.33.0.800.g4c38ced690-goog



More information about the libcamera-devel mailing list