[libcamera-devel] [PATCH] android: camera_stream: Set right format for processor output buffer

Umang Jain umang.jain at ideasonboard.com
Tue Oct 5 19:30:02 CEST 2021


Hello,

Thanks for  the patch.

On 10/5/21 2:57 PM, Hirokazu Honda wrote:
> CameraStream always sets the format of processor output buffer to
> MJPEG. This fixes the issue.
>
> Signed-off-by: Hirokazu Honda <hiroh at chromium.org>


Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>

I'll push the patch in sometime.

> ---
>   src/android/camera_stream.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp
> index e80f842d..db8d854b 100644
> --- a/src/android/camera_stream.cpp
> +++ b/src/android/camera_stream.cpp
> @@ -168,7 +168,7 @@ int CameraStream::process(const FrameBuffer &source,
>   	 * separate thread.
>   	 */
>   	const StreamConfiguration &output = configuration();
> -	CameraBuffer dest(*camera3Dest.buffer, formats::MJPEG, output.size,
> +	CameraBuffer dest(*camera3Dest.buffer, output.pixelFormat, output.size,
>   			  PROT_READ | PROT_WRITE);
>   	if (!dest.isValid()) {
>   		LOG(HAL, Error) << "Failed to map android blob buffer";


More information about the libcamera-devel mailing list