[libcamera-devel] [PATCH v2 08/17] android: capabilities: Use per-configuration durations
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Wed Oct 6 03:37:56 CEST 2021
Hi Jacopo,
Thank you for the patch.
On Tue, Sep 07, 2021 at 09:40:58PM +0200, Jacopo Mondi wrote:
> Use the per-configuration stream durations as collected during
> initializeStreamConfigurations() to populate the
> ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS_OUTPUT static metadata.
>
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>
> Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> src/android/camera_capabilities.cpp | 21 +++++++++------------
> 1 file changed, 9 insertions(+), 12 deletions(-)
>
> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp
> index ee2883ab2821..5d8293843f57 100644
> --- a/src/android/camera_capabilities.cpp
> +++ b/src/android/camera_capabilities.cpp
> @@ -1271,19 +1271,16 @@ int CameraCapabilities::initializeStaticMetadata()
> staticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_STALL_DURATIONS,
> availableStallDurations);
>
> - /* Use the minimum frame duration for all the YUV/RGB formats. */
> - if (minFrameDurationNsec > 0) {
> - std::vector<int64_t> minFrameDurations;
> - minFrameDurations.reserve(streamConfigurations_.size() * 4);
> - for (const auto &entry : streamConfigurations_) {
> - minFrameDurations.push_back(entry.androidFormat);
> - minFrameDurations.push_back(entry.resolution.width);
> - minFrameDurations.push_back(entry.resolution.height);
> - minFrameDurations.push_back(minFrameDurationNsec);
> - }
> - staticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS,
> - minFrameDurations);
> + std::vector<int64_t> minFrameDurations;
> + minFrameDurations.reserve(streamConfigurations_.size() * 4);
> + for (const auto &entry : streamConfigurations_) {
> + minFrameDurations.push_back(entry.androidFormat);
> + minFrameDurations.push_back(entry.resolution.width);
> + minFrameDurations.push_back(entry.resolution.height);
> + minFrameDurations.push_back(entry.minFrameDurationNsec);
> }
> + staticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS,
> + minFrameDurations);
>
> uint8_t croppingType = ANDROID_SCALER_CROPPING_TYPE_CENTER_ONLY;
> staticMetadata_->addEntry(ANDROID_SCALER_CROPPING_TYPE, croppingType);
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list