[libcamera-devel] [PATCH 2/2] android: camera_stream: Fix error message for buffer creation

[Hirokazu Honda]

Hi Umang, thank you for the patch.

On Thu, Oct 7, 2021 at 6:39 PM Umang Jain <umang.jain at ideasonboard.com> wrote:
>
> From: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>
> Creating a CameraBuffer instance doesn't map memory. Fix the error
> message accordingly.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>
> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>

Reviewed-by: Hirokazu Honda <hiroh at chromium.org>

> ---
>  src/android/camera_stream.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp
> index db8d854b..3b96d2e9 100644
> --- a/src/android/camera_stream.cpp
> +++ b/src/android/camera_stream.cpp
> @@ -171,7 +171,7 @@ int CameraStream::process(const FrameBuffer &source,
>         CameraBuffer dest(*camera3Dest.buffer, output.pixelFormat, output.size,
>                           PROT_READ | PROT_WRITE);
>         if (!dest.isValid()) {
> -               LOG(HAL, Error) << "Failed to map android blob buffer";
> +               LOG(HAL, Error) << "Failed to create destination buffer";
>                 return -EINVAL;
>         }
>
> --
> 2.31.1
>