[libcamera-devel] [PATCH 02/13] ipa: ipu3: set frameContext before controls

[Kieran Bingham]

Quoting Jean-Michel Hautbois (2021-10-13 16:41:14)

Missing some context here. Is this correct? If not put something that's
a bit more correct please ;-)

"""
The AGC frame context needs to be initialised correctly for the first
iteration.

Set the gain and exposure appropriately to the current values known to
the IPA.
"""


Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>
> ---
>  src/ipa/ipu3/ipu3.cpp | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
> index 6d9bbf39..e54fbab5 100644
> --- a/src/ipa/ipu3/ipu3.cpp
> +++ b/src/ipa/ipu3/ipu3.cpp
> @@ -415,6 +415,9 @@ int IPAIPU3::configure(const IPAConfigInfo &configInfo)
>                         return ret;
>         }
>  
> +       context_.frameContext.agc.gain = camHelper_->gain(gain_);
> +       context_.frameContext.agc.exposure = exposure_;
> +
>         return 0;
>  }
>  
> -- 
> 2.30.2
>